Skip to content

[Trivial] Fix C++ header after PR #6001.#6038

Merged
dnadlinger merged 1 commit intodlang:masterfrom
JohanEngelen:virtuals2
Aug 8, 2016
Merged

[Trivial] Fix C++ header after PR #6001.#6038
dnadlinger merged 1 commit intodlang:masterfrom
JohanEngelen:virtuals2

Conversation

@JohanEngelen
Copy link
Contributor

This module.h header change should have been part of #6001.

Ping @yebblies

JohanEngelen added a commit to JohanEngelen/ldc that referenced this pull request Aug 8, 2016
This eliminates the hidden-virtuals warning flood.

See
dlang/dmd#6001
dlang/dmd@60f622f
and
dlang/dmd#6038
@dnadlinger
Copy link
Contributor

Auto-merge toggled on

@wilzbach
Copy link
Contributor

wilzbach commented Aug 8, 2016

This module.h header change should have been part of #6001.

Yet another good example on how important #5082 would be ;-)

@JohanEngelen
Copy link
Contributor Author

JohanEngelen commented Aug 8, 2016

Yet another good example on how important #5082 would be ;-)

Definitely.

Sorry for not including it in #6001 . Was super surprised not to see it (edit) while applying it to LDC.

@dnadlinger dnadlinger merged commit 40fc716 into dlang:master Aug 8, 2016
@JohanEngelen JohanEngelen deleted the virtuals2 branch August 8, 2016 18:09
JohanEngelen added a commit to JohanEngelen/dmd that referenced this pull request Jun 25, 2017
… part of reverting dlang#6001

This reverts commit 40fc716, reversing
changes made to 3cec8aa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants