Merged
Conversation
return scope: first support
[scope] allow taking address of local in @safe code
refactor: .safe to .vsafe
sync printfs with master
revert changes to closure detection
infer return for 'maybescope' too
treat &a[i] same as &a if 'a' is static array
track assignment to static array member
stop escaping via initialization of 'this'
restrict escape this check to scope preview
fix Issue 16747 - Cannot have stack allocated classes in @safe code
Merge pull request #6279 from WalterBright/fix16747
fix improper determination of 'return this' status
fix Issue 17029 - [Reg 2.072] scope variable may not be returned # Conflicts: # src/escape.d
Merge pull request #6363 from WalterBright/fix17029
…_scope Conflicts: src/escape.d src/func.d src/globals.d src/mars.d src/mtype.d src/statementsem.d test/fail_compilation/test16193.d
Merge remote-tracking branch 'upstream/master' into merge_master_into_scope
- was active without any flags (-transition=safe) - implementation of check w/ -transition=safe still seems incorrect
lvalues should be checked for escapes, not rvalues
Member
|
thanks, @MartinNowak |
Member
Author
|
Can we please keep using a feature branch for all the changes and fixes until 2.074? Delete all the scope branches in the dlang repo now, but we can easily recreated them. |
Member
|
why? Now it's just conventional bug reports and fixes for dip1000 issues. |
Contributor
Member
|
This pull request introduced a regression: |
Member
An example of why I don't like feature branches - somewhere in 1500 lines of changes is the problem. |
Member
|
It's usually not a problem to bisect inside the branch, it's just that Digger is not set up to do it by default. |
Member
|
Bisected it down to the scope PR and commit -> #5972 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended as feature preview (hidden behind a switch). The implementation might still have a few bugs, but we want to test the design with a slightly broader audience.