remove helper functions for assert and unittest#6530
Merged
andralex merged 1 commit intodlang:masterfrom Feb 12, 2017
Merged
Conversation
Member
Author
|
This isn't ready yet. |
Member
Direct calls to _d_unittest* and _d_assert* you mean.
Why? We have several known issues/drawbacks w/ dragged in ModuleInfos. Are you trying to avoid redundant strings? I think linkers already deduplicate strings. |
bf03387 to
3d62ab8
Compare
Member
Author
|
I changed the ModuleInfo pointer to a simple char* for the filename. This eliminates dependency on ModuleInfo, and eliminates problems with accessing the internal functions in shared libraries. But it is blocked by dlang/druntime#1761 |
652a11b to
b42ea22
Compare
Member
|
This is a welcome simplification. |
b42ea22 to
6c001bb
Compare
Member
Author
|
@andralex ready to go! |
Member
|
What about array bounds checks? |
Member
|
This causes my test-setup to fail :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
This makes using
assertandunittestmore pay-as-you-go, which can result in more code generated (though not more code executed). Of course, the extra code doesn't matter forunittestasserts.Undone is the array bounds check, which I'll do if this goes through.