This repository was archived by the owner on Oct 12, 2022. It is now read-only.
add _d_assertp, _d_unittestp, _d_arrayboundsp#1761
Merged
WalterBright merged 1 commit intodlang:masterfrom Feb 10, 2017
Merged
Conversation
WalterBright
force-pushed
the
assertp
branch
from
5c5720c to
358b58e
Compare
WalterBright
force-pushed
the
assertp
branch
from
358b58e to
68a31f3
Compare
| /* One of these three is called upon an assert() fail. | ||
| */ | ||
| void _d_assertm(immutable(ModuleInfo)* m, uint line) | ||
| void _d_assertp(immutable(char)* file, uint line) |
Contributor
There was a problem hiding this comment.
Can file be passed as a D string directly?
Contributor
There was a problem hiding this comment.
I believe the idea is to reduce the amount of machine code needed at the call site.
Contributor
There was a problem hiding this comment.
And a D string would require this? I mean, I have no idea about these things.
Contributor
There was a problem hiding this comment.
There would be an extra register push (on x86_64, or depending on whatever other target ABI a stack store) to set up the length argument.
Member
Author
|
Blocking dlang/dmd#6530 |
dnadlinger
approved these changes
Feb 10, 2017
Contributor
|
Auto-merge toggled on |
Contributor
|
DAutoTest is still failing… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "m" functions are no longer used. The "p" versions use fewer bytes of code to call. The efficiency loss with the strlen is irrelevant.