Remove import of dmd.compiler from dmd.globals.#7615
Closed
ibuclaw wants to merge 1 commit intodlang:masterfrom
Closed
Remove import of dmd.compiler from dmd.globals.#7615ibuclaw wants to merge 1 commit intodlang:masterfrom
ibuclaw wants to merge 1 commit intodlang:masterfrom
Conversation
ibuclaw
added
the
Review:Blocking Other Work
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
ibuclaw
force-pushed
the
staticcompiler
branch
from
38676be to
64290bc
Compare
ibuclaw
force-pushed
the
staticcompiler
branch
from
64290bc to
b954bad
Compare
wilzbach
reviewed
Jan 6, 2018
| { | ||
| global.vendor = "Digital Mars D"; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
As discussed on IRC: how about making Compiler an interface instead?
Member
Author
There was a problem hiding this comment.
I've given it some thought and I'd rather avoid this if possible. Having to maintain interfaces seems like a last resort solution. For sure though Global._init is a big problem to tackle, as a big chunk of it should go into Target, but the globals module cannot import target!
I'll start off with adding initGlobals and see where we go from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocking #7534 and #7559, as the D implementation is less encapsulated than C++ version.