Move loadModule and paintAsType from Target to Compiler#7559
Move loadModule and paintAsType from Target to Compiler#7559dlang-bot merged 1 commit intodlang:masterfrom
Conversation
ibuclaw
requested review from
MartinNowak,
WalterBright and
wilzbach
as code owners
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#7559" |
ibuclaw
force-pushed
the
mvtargetcompiler
branch
from
eed279f to
f9b3ccc
Compare
wilzbach
force-pushed
the
mvtargetcompiler
branch
from
f9b3ccc to
6e2357c
Compare
|
(rebased) |
dlang-bot
added
Review:Needs Work
Review:Needs Rebase
and removed
Review:Needs Work
Review:Needs Rebase
labels
wilzbach
force-pushed
the
mvtargetcompiler
branch
from
6e2357c to
24253ba
Compare
src/posix.mak
Outdated
|
|
||
| $G/lexer.a: $(LEXER_SRCS) $(LEXER_ROOT) $(HOST_DMD_PATH) $(SRC_MAKE) | ||
| CC="$(HOST_CXX)" $(HOST_DMD_RUN) -lib -of$@ $(MODEL_FLAG) -J$G -L-lstdc++ $(DFLAGS) $(LEXER_SRCS) $(LEXER_ROOT) | ||
| CC="$(HOST_CXX)" $(HOST_DMD_RUN) -lib -of$@ $(MODEL_FLAG) -J$G -J../res -L-lstdc++ $(DFLAGS) $(LEXER_SRCS) $(LEXER_ROOT) |
There was a problem hiding this comment.
The additional -J switch appears to have nothing to do with this PR.
There was a problem hiding this comment.
The circular import adds extra module dependencies on the bare bones "lexer" library. I have been making other PRs to reduce the effect of this, but ultimately will probably move the vendor field back to globals for now.
There was a problem hiding this comment.
Ok. The rest of the PR looks good to me.
There was a problem hiding this comment.
Can we remove the lexer library from the makefiles? We already have the Dub package.
ibuclaw
force-pushed
the
mvtargetcompiler
branch
from
24253ba to
df57a7f
Compare
|
Rebased. |
ibuclaw
force-pushed
the
mvtargetcompiler
branch
from
df57a7f to
677c32a
Compare
|
Rebased again. |
6 participants
These are a couple of funny little functions that are compiler-specific, but are not directly related to the target platform.