dmd.globals: Move vendor string back to Global struct#8780
Merged
dlang-bot merged 1 commit intodlang:masterfrom Oct 1, 2018
Merged
dmd.globals: Move vendor string back to Global struct#8780dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
ibuclaw
added
Compiler:GDC
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8780" |
Member
|
Circular dependencies? dmd.compiler doesn't import anything. It has no dependencies, circular or otherwise. |
Member
Author
|
@WalterBright see the referenced PRs that begin moving routines into it. |
RazvanN7
approved these changes
Oct 1, 2018
Contributor
|
Even after this gets merged, #7534 still won't be able to get merged as it currently is because it adds semantic dependencies into a file that is used by the parser. |
Member
Author
|
@RazvanN7 it shouldn't. All functionality being added is part of the semantic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocking #7534 and #7559, due to the circular dependencies that happen between dmd.compiler and dmd.globals.