Avoid eager error message allocation with functionResolve#8232
Avoid eager error message allocation with functionResolve#8232RazvanN7 merged 1 commit intodlang:stablefrom
functionResolve#8232Conversation
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#8232" |
|
Since this is a critical regression, please target stable instead of master. |
|
@Geod24 Could you please test this locally for your use case and let us know if it resolves the issue you encountered? |
| const(char)* failMessage; | ||
| functionResolve(&m, s, loc, sc, tiargs, tthis, fargs, &failMessage); | ||
| functionResolve(&m, s, loc, sc, tiargs, tthis, fargs, null); | ||
| auto orig_s = s; |
There was a problem hiding this comment.
Why the extra reference? You can just use s.
There was a problem hiding this comment.
|
ping @ntrel . What's the status on this? |
4 participants
failMessagewithfunctionResolveuntil it's needed.This is a less drastic fix than #8216. In particular, this pull does not cause problems for #7584. The latter pull is a good example of why
functionResolvecannot just return a parameter index and create the error message on the caller side.