Skip to content

Comments

[perf] Don't allocate argument mismatch string when errors gagged#8281

Merged
RazvanN7 merged 1 commit intodlang:stablefrom
ntrel:gag-mismatch
May 23, 2018
Merged

[perf] Don't allocate argument mismatch string when errors gagged#8281
RazvanN7 merged 1 commit intodlang:stablefrom
ntrel:gag-mismatch

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented May 23, 2018

@Geod24 This should fix the high memory use found here (Note: #8232 already helped this somewhat).

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#8281"

@RazvanN7 RazvanN7 merged commit 362059d into dlang:stable May 23, 2018
@ntrel ntrel deleted the gag-mismatch branch May 23, 2018 14:37
@Geod24
Copy link
Member

Geod24 commented May 24, 2018

@ntrel : Thanks for taking care of this! Glad you could come up with a solution. I didn't have much time to look into D since DConf, but I'll try to build my project from stable this weekend and see if memory usage has returned to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants