Skip to content

Comments

Support magic __c_(u)longlong enums (for C++ mangling)#8262

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
kinke:master
May 23, 2018
Merged

Support magic __c_(u)longlong enums (for C++ mangling)#8262
RazvanN7 merged 1 commit intodlang:masterfrom
kinke:master

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented May 18, 2018

Make C++ long long representable in D on non-Apple 64-bit POSIX targets.

The commented-out tests require druntime changes, PR incoming.

@kinke kinke requested review from dnadlinger and ibuclaw as code owners May 18, 2018 22:11
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8262"

@ibuclaw
Copy link
Member

ibuclaw commented May 19, 2018

Looks ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants