Skip to content

Comments

[Trivial] Enable commented-out C++ mangling tests wrt. cpp_{longlong,size_t}#8284

Merged
dlang-bot merged 1 commit intodlang:masterfrom
kinke:__c_longlong
May 24, 2018
Merged

[Trivial] Enable commented-out C++ mangling tests wrt. cpp_{longlong,size_t}#8284
dlang-bot merged 1 commit intodlang:masterfrom
kinke:__c_longlong

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented May 23, 2018

As follow-up to #8262.

@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label May 23, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8284"

@dlang-bot dlang-bot merged commit a35e8e4 into dlang:master May 24, 2018
@kinke kinke deleted the __c_longlong branch May 24, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants