Implement GccAsmStatement for gcc-style asm statements

[ibuclaw]

The AST itself is only used by GDC.

Parser and semantic analysis has been merged into a single function, and put in its own module as per #7562 (comment).

Lots more documentation could be added to the new functions that implement gcc asm.

Closes #7562.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8538"

[ibuclaw]

As title update suggests, renamed class to GccAsmStatement to avoid ambiguity.

Added ddoc style comments, along with grammar outline of the parser.

[wilzbach]

Reviewing this commit by commit was really straight-forward. Thank you!

[wilzbach]

Could be an foreach ;-)

[wilzbach]

Could be a foreach (and the two for loops below too)

[ibuclaw]

If you mean foreach (i; 0 .. s.args.dim), then ok.

[ibuclaw]

Rebased; tweaked documented grammar so that there is no distinction between input and output operands; use foreach in a few places.

[ibuclaw]

@WalterBright - This is good to review I guess.

[jacob-carlborg]

Can tests be added?

[ibuclaw]

@jacob-carlborg unittests mimicking gdc? I guess so...

[jacob-carlborg]

jacob-carlborg unittests mimicking gdc? I guess so..

I had a few ideas:

1. Use more of an integration/unit test style approach instead of the current end-to-end
2. Tests that shows what happens if DMD is trying to use this new statement
3. Can we have tests that are only executed by GDC? We are running GDC using SemaphoreCI, as far as I know

Unless somebody has a better idea.

[ibuclaw]

Use more of an integration/unit test style approach instead of the current end-to-end

See latest commit.

Tests that shows what happens if DMD is trying to use this new statement

DMD will always treat it like a dmd asm statement, so will error in same way as before.

Can we have tests that are only executed by GDC? We are running GDC using SemaphoreCI, as far as I know

That doesn't really help at all if we make changes to it, as for proper testing you should build GDC from source. You should probably have some faith in me that I vet my own compiler. :-)

[jacob-carlborg]

That doesn't really help at all if we make changes to it, as for proper testing you should build GDC from source. You should probably have some faith in me that I vet my own compiler

Yes, but you're making changes to a project without adding tests to the project. But now I see that you've added tests 👍.

[PetarKirov]

Nice work on the code and git commit separation!

[wilzbach]

SemaphoreCI failure is due to it checking out the wrong branch. This should be fixed by #8560 (once it's merged into stable and merged to master).

[ibuclaw]

:-O