Fix Semaphore stable branch detection#8560
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#8560" |
... works as expected :) |
|
The DAutoTest failure is unrelated, see e.g. dlang/dlang.org#2432 |
|
Could we maybe prioritize this PR? It seems that SemaphoreCI has become a bit flaky and this should hopefully fix the red check we experienced on a few PRs over the last days. Once this is merged into |
|
@wilzbach LGTM as well. Feel free to force merge. |
|
The previously used detection didn't work which lead to the current problems of the wrong branch being checked out.
The GitHub API is rate-limited and thus this isn't ideal, but we already use the same workaround for the CircleCI:
dmd/.circleci/run.sh
Lines 84 to 88 in ecde30e