Skip to content

Fix Issue 19152 - 2.081.1 Regression - Seg fault in traits.d#8553

Merged
wilzbach merged 1 commit intodlang:stablefrom
JinShil:fix_19152
Aug 14, 2018
Merged

Fix Issue 19152 - 2.081.1 Regression - Seg fault in traits.d#8553
wilzbach merged 1 commit intodlang:stablefrom
JinShil:fix_19152

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 10, 2018

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 10, 2018

Thanks for your pull request, @JinShil!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 19152 regression 2.081.1 Regression compiler bug

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#8553"

@JinShil
Copy link
Contributor Author

JinShil commented Aug 10, 2018 •
edited
Loading

What's going on with src/core/sys/posix/sys/statvfs.d and GDC in Semaphore CI? statvfs.d was modified in dlang/druntime#2265, but that had targeted master, not stable. This PR is targeting stable

cc @ibuclaw @jmdavis @wilzbach

@jmdavis
Copy link
Member

jmdavis commented Aug 10, 2018

It looks like it can't handled enum members being deprecated, which is a very recent feature.

jacob-carlborg
jacob-carlborg reviewed Aug 10, 2018
View reviewed changes
test/compilable/test19152.d
auto name = __traits(getOverloads, this, "OnExecute").stringof;
return 0;
}
}
Copy link
Contributor

@jacob-carlborg jacob-carlborg Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an existing file this can be added to? This will reduce the total execution time of the tests.

Copy link
Contributor Author

@JinShil JinShil Aug 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find an obvious fit in test/compilable. Shall I start a new file called traits.d to contain all future traits-related tests?

Copy link
Contributor

@jacob-carlborg jacob-carlborg Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine by me.

@JinShil
Copy link
Contributor Author

JinShil commented Aug 10, 2018 •
edited
Loading

It looks like LDC is experiencing the same error as GDC in Semaphore CI. Is the CI using the correct druntime code?

@wilzbach
Copy link
Contributor

wilzbach commented Aug 13, 2018 •
edited
Loading

Is the CI using the correct druntime code?

Doesn't look like it. #8560 should fix this.

(repushed this in the meanwhile to restart DAutoTest.)

@wilzbach wilzbach added this to the 2.082.0 milestone Aug 13, 2018
@wilzbach wilzbach merged commit 5445a82 into dlang:stable Aug 14, 2018
@JinShil JinShil deleted the fix_19152 branch August 14, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

+2 more reviewers

@jacob-carlborg jacob-carlborg jacob-carlborg approved these changes

@wilzbach wilzbach wilzbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Severity:Bug Fix

Projects

None yet

Milestone

2.082.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JinShil @dlang-bot @jmdavis @wilzbach @jacob-carlborg @RazvanN7