Skip to content

[stable] Fix -mixin output for CRLF input#9119

Merged
dlang-bot merged 1 commit intodlang:stablefrom
kinke:fixMixin
Dec 24, 2018
Merged

[stable] Fix -mixin output for CRLF input#9119
dlang-bot merged 1 commit intodlang:stablefrom
kinke:fixMixin

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Dec 22, 2018

The mixin string may contain Windows newlines, e.g., if the source file does and a multiline q{ ... } literal is used (e.g., test/runnable/extra-files/mixin.d). In that case, the old code would output CRLF on POSIX and CRCRLF on Windows instead of normalizing the output (LF/CRLF).

The mixin string may contain Windows newlines, e.g., if the source file
does and a multiline `q{ ... }` literal is used (e.g.,
test/runnable/extra-files/mixin.d). In that case, the old code would
output CRLF on POSIX and CRCRLF on Windows instead of normalizing the
output (LF/CRLF).
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9119"

kinke added a commit to kinke/ldc that referenced this pull request Dec 22, 2018
@dlang-bot dlang-bot merged commit faca601 into dlang:stable Dec 24, 2018
@kinke kinke deleted the fixMixin branch December 24, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants