Skip to content

[stable] Fix silly dmd.parse regression#9212

Merged
WalterBright merged 1 commit intodlang:stablefrom
kinke:fixMixin
Jan 7, 2019
Merged

[stable] Fix silly dmd.parse regression#9212
WalterBright merged 1 commit intodlang:stablefrom
kinke:fixMixin

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Jan 6, 2019

Sorry; introduced in #9119.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9212"

@kinke kinke changed the title Fix silly dmd.parse regression [stable] Fix silly dmd.parse regression Jan 6, 2019
@WalterBright
Copy link
Member

Since this was a regression, and there have been many involving incorrect conversions of for loops to foreach, can you supply a test case to ensure it doesn't happen again?

@kinke
Copy link
Contributor Author

kinke commented Jan 7, 2019

Existing testcase slightly extended to cover both line endings, independent from used autocrlf git setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants