fix Issue 19636 - ICE: writing mixin to file crashes if the text contains CRLF#9306
Closed
rainers wants to merge 1 commit intodlang:masterfrom
Closed
fix Issue 19636 - ICE: writing mixin to file crashes if the text contains CRLF#9306rainers wants to merge 1 commit intodlang:masterfrom
rainers wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @rainers! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9306" |
thewilsonator
approved these changes
Jan 31, 2019
PetarKirov
approved these changes
Jan 31, 2019
Member
PetarKirov
left a comment
PetarKirov
left a comment
There was a problem hiding this comment.
Target the stable branch, otherwise LGTM.
WalterBright
approved these changes
Jan 31, 2019
Member
Author
|
It seems it is already fixed on stable... #9212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also avoid auto-decoding