testptrref: fix finding TLS range#9341
Merged
WalterBright merged 1 commit intodlang:masterfrom Feb 10, 2019
Merged
Conversation
Contributor
BTW partially OT, but if we ever want to add more Windows jobs, run into problems with AppVeyor or simply overclog the queue with AppVeyor (we only have one free job there), Azure CI pipelines might be an option. As an open-source project, one gets 10 parallel jobs for free: https://azure.microsoft.com/en-us/services/devops/pipelines/ I saw that the LDC people are testing this out too at the moment: |
jacob-carlborg
approved these changes
Feb 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why this test didn't fail for me or on Appveyor, but it does now (probably after an update to the VC toolchain). As noted in dlang/druntime#1910: With VS2017 15.3.1 segment .tls is no longer written to a separate image section, so _tls_start and _tls_end no longer happen to work as both __gshared and TLS section offsets.
This now uses the TLS detection from druntime.