fix issue 17788: MSCOFF: TLS broken with VS2017 15.3.1#1910
fix issue 17788: MSCOFF: TLS broken with VS2017 15.3.1#1910PetarKirov merged 2 commits intodlang:stablefrom
Conversation
|
Thanks for your pull request, @rainers! Bugzilla references
|
|
@rainers: Does this affect LDC as well? It seems like we are using the same code. |
|
@rainers how confident are you with this solution, should we try to include it the next beta of 2.076.0? |
src/rt/sections_win64.d
Outdated
| void* pend; | ||
| version(Win32) | ||
| { | ||
| asm @nogc nothrow |
There was a problem hiding this comment.
Shouldn't this be guarded by D_InlineAsm too?
Yes, see ldc-developers/ldc#2279 (comment)
Should work for all VC at least back to VS2005, they all use _tls_used for the TLS directory. I'll retarget stable if it passes. There are also other issues with this VS update that break Visual D, though.
Yeah, probably better. I replaced Win32 with D_InlineAsm_X86, etc. |
Great to hear, I've added this to the 2.076.0 milestone. CC @MartinNowak |
… written to a separate image section, so _tls_start and _tls_end no longer happen to work as both __gshared and TLS section offsets.
|
rebased to stable. |
|
We'll 'need' this for LDC 1.4 final. |
|
DAutoTest failure is unrelated. |
6 participants
with VS2017 15.3.1 segment .tls is no longer written to a separate image section, so _tls_start and _tls_end no longer happen to work as both __gshared and TLS section offsets.