Turn deprecation into error for privately imported symbols

[RazvanN7]

No description provided.

[dlang-bot]

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9393"

[jacob-carlborg]

To we really want to do this before all __traits has been loosened, #9325?

[RazvanN7]

To we really want to do this before all __traits has been loosened, #9325?

Looking at the code in #9325 , it seems that it should not be affected by this PR.

[jacob-carlborg]

Perhaps it's time to notify the owners of the projects that fail to build in buildkit, or start making PRs to those projects.

[wilzbach]

Needs a short changelog entry, s.t. it's easier to for users to find potential problems when upgrading and knowing in which version the change was introduced.

[RazvanN7]

So... I've made PRs to fix all the failing projects (or dependencies of failing projects); now we have to wait for the authors to merge and push new tags

[wilzbach]

we have to wait for the authors to merge and push new tags

FYI: if they don't respond within a reasonable time frame (typically three days or so), we can remove these projects from buildkite. We have done this before for semi-dead projects.

[wilzbach]

Ocean just released a new version yesterday with @razvan's fix, so this is only missing a changelog entry to be good to go.

[rainers]

There are a couple of more places where a similar deprecation is emitted. grep for is not visible from module.

[RazvanN7]

Changelog entry added.

[jacob-carlborg]

There are a couple of more places where a similar deprecation is emitted. grep for is not visible from module.

Yeah, I got 8 hits.

[RazvanN7]

There are a couple of more places where a similar deprecation is emitted. grep for is not visible from module.

Those can be treated in subsequent PRs as they deprecate in slightly different situations.

[thewilsonator]

There are a couple of more places where a similar deprecation is emitted. grep for is not visible from module.

Those can be treated in subsequent PRs as they deprecate in slightly different situations.

OK, lets not keep this waiting.