Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this is blocking [1]. Please take a look at the changelog entry in [1]. Vibe-d is failing because of this. A few explanations: the declaration
enum Statushas the attributepackage(on top of the module; I suggest you leave one empty line before and after the declaration because it is extremely easy to overlook it), which means that it is accessible only inside the libasync package; however, vibe.d usesStatusandisIpv6also, so I made them public. I realize this may not be the best solution as those were not intended for external use, but I am not sufficiently familiar with your code to make a more elegant fix. After this issue is fixed (my merging this PR or any other way) please push a new tag so that vibe-d will appropriately use the latest version of libasync.[1] dlang/dmd#9393