Skip to content

Add changelog entry for Markdown features in Ddoc#9645

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dgileadi:markdown-changelog
Apr 18, 2019
Merged

Add changelog entry for Markdown features in Ddoc#9645
dlang-bot merged 1 commit intodlang:masterfrom
dgileadi:markdown-changelog

Conversation

@dgileadi
Copy link
Contributor

Note that this references the changed documentation in this dlang.org PR.

Also I hope this is the way to make a changelog entry—please let me know if I got it wrong.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dgileadi! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9645"

@dlang-bot dlang-bot merged commit c77fc7c into dlang:master Apr 18, 2019
@PetarKirov
Copy link
Member

We're not yet building the pages on dlang.org with -preview=markdown.

@wilzbach, what is necessary to change this?

@wilzbach
Copy link
Contributor

Enabling it for dlang.org.

@@ -0,0 +1,5 @@
Add Markdown-inspired features to Ddoc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we typically don't use dots in the title (this is the menu item and will be used in the generated changelog TOC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants