Render TypeInfo_Struct.xopCmp ABI-agnostic wrt. parameter order#1417
Render TypeInfo_Struct.xopCmp ABI-agnostic wrt. parameter order#1417kinke wants to merge 1 commit intodlang:masterfrom
Conversation
|
What's the status of this @kinke? |
|
Hmm it's been a long time - haven't some functions been templatized recently? If these 2 are, the problem should be solved. |
|
I'm not aware of these being converted to templates. You may want to check dmd/clone.d also. |
|
Thanks for your pull request, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
(Sorry, I just found out I have accidentally closed this PR from my phone) @kinke The only two template-ized operations are array comparison (https://github.com/dlang/dmd/pull/6597/files) and array ops (dlang/dmd#7032) so it looks like this PR still may be needed. I don't know how soon we'll be able to get rid of of the use of TypeInfo for this kind of stuff, but probably we should continue to template-ize druntime so it can work in a more pay as you go manner, solving the issue @kinke is trying to address here as nice side effect. |
|
Tested against gdc, and confirmed that this works for us too. |
|
Rebased this in #2025 |
No description provided.