Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Render TypeInfo_Struct.xopCmp ABI-agnostic wrt. parameter order#1417

Closed
kinke wants to merge 1 commit intodlang:masterfrom
kinke:xopcmp
Closed

Render TypeInfo_Struct.xopCmp ABI-agnostic wrt. parameter order#1417
kinke wants to merge 1 commit intodlang:masterfrom
kinke:xopcmp

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Oct 26, 2015

No description provided.

@PetarKirov
Copy link
Member

What's the status of this @kinke?

@kinke
Copy link
Contributor Author

kinke commented Sep 1, 2017

Hmm it's been a long time - haven't some functions been templatized recently? If these 2 are, the problem should be solved.

@ibuclaw
Copy link
Member

ibuclaw commented Sep 3, 2017

I'm not aware of these being converted to templates.

You may want to check dmd/clone.d also.

@PetarKirov PetarKirov closed this Sep 3, 2017
@PetarKirov PetarKirov reopened this Sep 3, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@PetarKirov
Copy link
Member

(Sorry, I just found out I have accidentally closed this PR from my phone)

@kinke The only two template-ized operations are array comparison (https://github.com/dlang/dmd/pull/6597/files) and array ops (dlang/dmd#7032) so it looks like this PR still may be needed. I don't know how soon we'll be able to get rid of of the use of TypeInfo for this kind of stuff, but probably we should continue to template-ize druntime so it can work in a more pay as you go manner, solving the issue @kinke is trying to address here as nice side effect.

@ibuclaw
Copy link
Member

ibuclaw commented Dec 30, 2017

Tested against gdc, and confirmed that this works for us too.

@ibuclaw
Copy link
Member

ibuclaw commented Dec 31, 2017

Rebased this in #2025

@ibuclaw ibuclaw closed this Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants