This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Experimental: Don't reverse parameter order for extern(D) on x86_64.#19
Closed
kinke wants to merge 2 commits intoldc-developers:ldcfrom
Closed
Experimental: Don't reverse parameter order for extern(D) on x86_64.#19kinke wants to merge 2 commits intoldc-developers:ldcfrom
kinke wants to merge 2 commits intoldc-developers:ldcfrom
Conversation
kinke
force-pushed
the
noReverse
branch
6 times, most recently
from
ac9cfd7 to
943bd55
Compare
Member
Author
|
Upstream PR: dlang#1417 |
Member
Author
|
Has landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've grepped the code base for "naked" and then adapted inline assembly accessing function arguments in reversed order; i.e., by checking all naked non-vararg extern(D) functions with > 1 total parameters (incl. implicit ones like this and/or sret).
There may still be other non-naked assembly parts to be adapted.