Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/math.d
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ version (LDC)
asm
{
naked;
push RCX; // push exp (8 bytes), passed in ECX
push RDX; // push exp (8 bytes), passed in EDX
fild int ptr [RSP]; // push exp onto FPU stack
pop RCX; // return stack to initial state
fld real ptr [RDX]; // push n onto FPU stack, passed in [RDX]
pop RDX; // return stack to initial state
fld real ptr [RCX]; // push n onto FPU stack, passed in [RCX]
fscale; // ST(0) = ST(0) * 2^ST(1)
fstp ST(1); // pop stack maintaining top value => function return value
ret; // no arguments passed via stack
Expand Down
21 changes: 16 additions & 5 deletions src/object.d
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ class TypeInfo_Struct : TypeInfo
if (!p2)
return true;
else if (xopCmp)
return (*xopCmp)(p2, p1);
return (*xopCmp)(p1, p2);
else
// BUG: relies on the GC not moving objects
return memcmp(p1, p2, init().length);
Expand Down Expand Up @@ -1101,10 +1101,21 @@ class TypeInfo_Struct : TypeInfo

@safe pure nothrow
{
size_t function(in void*) xtoHash;
bool function(in void*, in void*) xopEquals;
int function(in void*, in void*) xopCmp;
string function(in void*) xtoString;
size_t function(in void*) xtoHash;
/* The xopEquals and xopCmp function pointers usually point to the struct's
* opEquals and opCmp methods. If the method doesn't take its single
* argument by reference, the front-end injects a static __xopEquals/
* __xopCmp function (taking 2 arguments, lhs `p` and rhs `q`).
*
* In the method case, lhs `p` is the `this` argument and must be passed
* as first argument before rhs `q`.
* Enforce this arguments order by marking the pointed-to functions as
* using the C calling convention, for which the arguments are never
* reversed (contrary to `extern (D)`).
*/
extern (C) bool function(in void*, in void*) xopEquals;
extern (C) int function(in void*, in void*) xopCmp;
string function(in void*) xtoString;

enum StructFlags : uint
{
Expand Down