Experimental: Don't reverse parameter order for extern(D) on x86_64.#865
Closed
kinke wants to merge 3 commits intoldc-developers:masterfrom
Closed
Experimental: Don't reverse parameter order for extern(D) on x86_64.#865kinke wants to merge 3 commits intoldc-developers:masterfrom
kinke wants to merge 3 commits intoldc-developers:masterfrom
Conversation
Member
Author
|
I've just updated the druntime patch - I've previously missed |
d9436bc to
fac881d
Compare
Member
Author
|
It finally seems to be working now (except for the 32-bit tests). The front-end hack is ugly and can't be incorporated as-is, but I guess the proper location to fix it is the upstream front-end. |
fd28980 to
4c21b9b
Compare
Member
Author
|
Upstream PR: dlang/dmd#5232 |
To make sure the arguments order (p, q) isn't reversed. This is necessary as the TypeInfo_Struct's function pointers `xopEquals` and `xopCmp` normally map to the struct's `opEquals`/`opCmp` methods, for which lhs `p` must be passed as `this` argument before rhs `q`. These __ wrappers are only generated if the method doesn't take its single argument by reference.
Member
Author
|
Closing because this has finally been implemented in v1.29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ldc-developers/druntime#19 and ldc-developers/phobos#9.
Debug unittests pass on Linux x64 with LLVM 3.5, but dmd-testsuite reveals a serious bug:
a.sort() sorts the array in reversed order.