netbsd patch: core/sys/netbsd by sibnick · Pull Request #1493 · dlang/druntime

sibnick · 2016-02-04T07:53:18Z

A part of NetBSD support (joakim-noah suggests to split original big pull request)

joakim-noah · 2016-02-04T14:36:40Z

src/core/sys/netbsd/sys/cdefs.d

@@ -0,0 +1,16 @@
+/**
+ * D header file for FreeBSD
+ *


NetBSD header

joakim-noah · 2016-02-04T14:40:35Z

I diffed this PR against the pre-existing core.sys.netbsd: seems to mostly be a straight copy and rename, which is why the cdefs comment above is wrong and there are TODO comments that some files haven't been checked.

Fix that comment and the five remaining links to FreeBSD SVN headers, and I see no harm in merging.

sibnick · 2016-02-04T17:21:38Z

Fixed

ibuclaw · 2016-02-06T11:05:42Z

Do we have links to NetBSD reference C headers?

ibuclaw · 2016-02-06T11:08:26Z

What about Makefile changes to maybe compile and install these interface modules?

dnadlinger · 2016-02-06T17:43:30Z

LDC doesn't use the upstream build system, and DMD doesn't support NetBSD...

dnadlinger · 2016-02-06T17:44:37Z

Hmm, you might have a point regarding doc building. I always forget how that is handled, cross-platform-wise.

ibuclaw · 2016-02-07T08:32:29Z

LDC doesn't use the upstream build system, and DMD doesn't support NetBSD...

Documentation for those who could support it when the time comes to downstream. :-)

sibnick · 2016-02-09T03:00:03Z

Do we have links to NetBSD reference C headers?

Actual NetBSD layout is differ. Currently I have FreeBSD layout + NetBSD changes. I should reorganize elf related files to conform NetBSD headers.

codecov-io · 2017-01-31T08:40:12Z

Codecov Report

❗ No coverage uploaded for pull request head (netbsd_core_sys_netbsd@a9f4e7a).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bf08d...a9f4e7a. Read the comment docs.

joakim-noah · 2017-03-13T05:51:25Z

So I guess this still has to be reorganized to conform to the NetBSD layout? We try to keep these include files the same as the headers, so that would help.

sibnick · 2017-03-20T02:47:48Z

I added links to netbsd headers in each file and remove one file which is not related to netbsd.

joakim-noah

Downloaded and diffed this against the FreeBSD directory, looks pretty much the same with some tweaks. Try diffing it against the latest FreeBSD version and making any updates needed, like the alias syntax I mentioned. If you're happy with it after that, we might as well merge, considering the other NetBSD changes are in and we can always modify this later.

joakim-noah · 2017-03-26T07:50:42Z

src/core/sys/netbsd/dlfcn.d

+        int     __dlfunc_dummy;
+    };
+
+    alias void function(__dlfunc_arg) dlfunc_t;


Can you change this to the alias = syntax, as now done in the same FreeBSD module? Same with the __externC alias below.

joakim-noah · 2017-03-26T07:51:57Z

src/core/sys/netbsd/sys/link_elf.d

+private alias extern(C) int function(dl_phdr_info*, size_t, void *) @nogc dl_iterate_phdr_cb_ngc;
+extern int dl_iterate_phdr(dl_iterate_phdr_cb __callback, void*__data);
+extern int dl_iterate_phdr(dl_iterate_phdr_cb_ngc __callback, void*__data) @nogc;
+


Remove blank line.

sibnick · 2017-03-27T11:48:19Z

I fixed issues (alias & empty line). I did not find anything new in current FreeBSD sources. I agree to merge this PR now. I will wait while LDC team merge current druntime master to their repository and after this I can refresh unit tests status (new LDC, new druntime, and new NetBSD 7.1 too) and may be send additional PRs.

joakim-noah · 2017-04-03T15:29:51Z

src/core/sys/netbsd/dlfcn.d

+
+version (NetBSD):
+extern (C):
+nothrow:


FreeBSD file has @nogc attribute here, missing in yours. Why not add that attribute to all the header files?

Thanks, my fault - fixed

joakim-noah

Would be better if all the files had the@nogc attribute, but not a big deal.

joakim-noah · 2017-04-04T09:44:36Z

btw, it will take a while before these patches get to ldc, so let me know if you'd rather work with the beta 1.2 branch or master 1.3 branch and I will cherry-pick these commits for ldc earlier.

joakim-noah · 2017-04-08T18:27:29Z

Pinging @klickverbot, maybe Kai can announce NetBSD support at DConf. ;)

dnadlinger

This only continues what has been started already, so should be fine.

sibnick · 2017-04-09T14:25:28Z

joakim-noah
I am not sure about ldc branches 1.2 vs 1.3. I suppose 1.3 branch is better - the probability of merge conflicts is lower

joakim-noah · 2017-04-09T16:15:03Z

I've cherry-picked the three NetBSD druntime commits into ldc's master 1.3 branch. You will need to check out the latest druntime HEAD manually, until the submodule is updated.

sibnick mentioned this pull request Feb 4, 2016

NetBSD path #1492

Merged

joakim-noah reviewed Feb 4, 2016
View reviewed changes

src/core/sys/netbsd/sys/cdefs.d Outdated

@@ -0,0 +1,16 @@

/**

* D header file for FreeBSD

*

Copy link

Contributor

joakim-noah Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NetBSD header

sibnick force-pushed the netbsd_core_sys_netbsd branch from f3835cd to d460689 Compare February 4, 2016 17:19

sibnick force-pushed the netbsd_core_sys_netbsd branch from d460689 to a9955f4 Compare February 17, 2016 18:43

sibnick force-pushed the netbsd_core_sys_netbsd branch from a9955f4 to d7ad4d0 Compare February 27, 2016 11:03

sibnick force-pushed the netbsd_core_sys_netbsd branch 2 times, most recently from cbeac82 to 5960696 Compare March 6, 2016 15:02

sibnick force-pushed the netbsd_core_sys_netbsd branch from 5960696 to a9f4e7a Compare January 31, 2017 08:40

sibnick force-pushed the netbsd_core_sys_netbsd branch from a9f4e7a to 60e2a2f Compare February 1, 2017 02:43

sibnick force-pushed the netbsd_core_sys_netbsd branch from 60e2a2f to accddad Compare March 17, 2017 11:40

joakim-noah suggested changes Mar 26, 2017

View reviewed changes

sibnick force-pushed the netbsd_core_sys_netbsd branch from accddad to f7f2836 Compare March 27, 2017 08:34

joakim-noah reviewed Apr 3, 2017

View reviewed changes

netbsd patch: core/sys/netbsd

24bc730

sibnick force-pushed the netbsd_core_sys_netbsd branch from f7f2836 to 24bc730 Compare April 4, 2017 05:41

joakim-noah approved these changes Apr 4, 2017

View reviewed changes

dnadlinger approved these changes Apr 8, 2017

View reviewed changes

dnadlinger added the auto-merge label Apr 8, 2017

dlang-bot merged commit 9cfde10 into dlang:master Apr 8, 2017

Uh oh!

Conversation

sibnick commented Feb 4, 2016

Uh oh!

joakim-noah Feb 4, 2016

Choose a reason for hiding this comment

Uh oh!

joakim-noah commented Feb 4, 2016

Uh oh!

sibnick commented Feb 4, 2016

Uh oh!

ibuclaw commented Feb 6, 2016

Uh oh!

ibuclaw commented Feb 6, 2016

Uh oh!

dnadlinger commented Feb 6, 2016

Uh oh!

dnadlinger commented Feb 6, 2016

Uh oh!

ibuclaw commented Feb 7, 2016

Uh oh!

sibnick commented Feb 9, 2016

Uh oh!

codecov-io commented Jan 31, 2017

Codecov Report

Uh oh!

joakim-noah commented Mar 13, 2017

Uh oh!

sibnick commented Mar 20, 2017

Uh oh!

joakim-noah left a comment

Choose a reason for hiding this comment

Uh oh!

joakim-noah Mar 26, 2017

Choose a reason for hiding this comment

Uh oh!

joakim-noah Mar 26, 2017

Choose a reason for hiding this comment

Uh oh!

sibnick commented Mar 27, 2017

Uh oh!

joakim-noah Apr 3, 2017

Choose a reason for hiding this comment

Uh oh!

sibnick Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

joakim-noah left a comment

Choose a reason for hiding this comment

Uh oh!

joakim-noah commented Apr 4, 2017

Uh oh!

joakim-noah commented Apr 8, 2017

Uh oh!

dnadlinger left a comment

Choose a reason for hiding this comment

Uh oh!

sibnick commented Apr 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joakim-noah commented Apr 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sibnick commented Apr 9, 2017 •

edited

Loading

joakim-noah commented Apr 9, 2017 •

edited

Loading