Conversation
|
I suggest you split this up into 2-3 separate PRs, as it'll be a bear to review a 6k-line PR. Are you generally just copy-pasting the FreeBSD portions, or did you check if NetBSD does it differently? For example, |
|
Yes I checked. Actually many of them is not the same! core/sys/freebsd/time.d and core/sys/netbsd/time.d Can you suggest rule for patch splitting? |
|
I successfully run unit test (phobos, druntime), built dub (small issue in make file), run vibed unit tests, started several vibe.d samples. I found one trouble with web sockets (works with firefox, core dumped with chrome). I do not discover this issue yet. |
|
A way to split it that makes sense to me would be to submit your Good to hear you got dub and vibe.d running. :) |
|
Can we start from 1493, 1494 pull requests? May by I will change src/core/stdc/math.d (I am not sure). NetBSD has stubs for several long double (real type in dlang) functions. May be I will fix at least some of them. Actually I do it for logl function already. |
| enum EMULTIHOP = 94 /** Multihop attempted */; | ||
| enum ENOLINK = 95 /** Link has been severed */; | ||
| enum EPROTO = 96 /** Protocol error */; | ||
| } |
There was a problem hiding this comment.
It looks like you got these comments from the official NetBSD header, please replace them with blank comments, as seen for Linux. Comments are copyrightable, it is Walter's policy not to copy them.
|
Simply skimmed patch to make sure it won't mess with other platforms, ie everything is encapsulated for NetBSD, LGTM from that standpoint, plus found two formatting errors that should be fixed. |
|
remove comments and empty line |
|
Thanks, while I haven't checked the NetBSD declarations and functions, I see no harm in merging, since everything is encapsulated. |
sibnick
force-pushed
the
netbsd_patch
branch
7 times, most recently
from
fd421bc to
1118ff7
Compare
|
Looks like this and the other NetBSD PRs have rotted, after nobody merged them. Can you update them so auto-tester passes again and we'll try to get them merged finally? |
|
I updated all 3 PRs with NetBSD patches |
Codecov Report
Continue to review full report at Codecov.
|
|
Looks like you need to rebase. |
|
Rebase is performed. Initially I performed rebase with wrong branch. |
sibnick
force-pushed
the
netbsd_patch
branch
2 times, most recently
from
a79e0c5 to
e0f61f4
Compare
|
auto-tester passes on this pull request, but other two requests have pending items in auto-tester. I am not sure what does it means |
|
This NetBSD port, including #1493 and #1494, has been in limbo for a year now. Calling @MartinNowak, @ibuclaw, @WalterBright, can we get some feedback on what else needs to be done to get this merged? |
|
I just left this originally as I wanted to get some LDC-external reviews as well. @nrTQgc, could you please rebase so we can merge? |
|
I performed rebase |
| // alias core.stdc.complex.crealf creal; | ||
| // alias core.stdc.complex.creall creal; | ||
| } | ||
|
|
There was a problem hiding this comment.
This blank line slipped through, remove it in one of the already submitted NetBSD PRs.
There was a problem hiding this comment.
fixed in netbsd_core_sys_posix
6 participants
It is LDC based port. My pull request merged to LDC master already.
Druntime:
I decide try to repeat LDC team forkflow and cherry-pick my commit to ldc branch. There are a couple simple conflicts in src/core/stdc/locale.d & src/core/sys/posix/signal.d, and one absent (in master) file: src/rt/sections_ldc.d
I successfully build and run druntime unittests on NetBSD after resolving conflicts.