Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

netbsd patch: core/sys/posix#1494

Merged
dlang-bot merged 1 commit intodlang:masterfrom
sibnick:netbsd_core_sys_posix
Mar 15, 2017
Merged

netbsd patch: core/sys/posix#1494
dlang-bot merged 1 commit intodlang:masterfrom
sibnick:netbsd_core_sys_posix

Conversation

@sibnick
Copy link
Contributor

@sibnick sibnick commented Feb 4, 2016

A part of NetBSD support (joakim-noah suggests to split original big pull request)

@sibnick sibnick mentioned this pull request Feb 4, 2016
Merged
ibuclaw
ibuclaw reviewed Feb 4, 2016
View reviewed changes
src/core/sys/posix/arpa/inet.d Outdated
int inet_pton(int, in char*, void*);
}

else version( Solaris )
Copy link
Member

@ibuclaw ibuclaw Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've also added a solaris path here. :-)

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from ac5855e to 5561966 Compare February 4, 2016 08:50
ibuclaw
ibuclaw reviewed Feb 4, 2016
View reviewed changes
src/core/sys/posix/dirent.d
else
{
DIR* opendir(in char*);
}
Copy link
Member

@ibuclaw ibuclaw Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual penance if you discover a discrepancy on one platform is to write a version block for each known tested platform, using static assert (0) for the else branch.

This alerts the next person who will port this code to go check and verify that it's defined properly.

@sibnick
Copy link
Contributor Author

sibnick commented Feb 4, 2016

to ibuclaw : fixed (remove solaris duplicate block)

ibuclaw
ibuclaw reviewed Feb 4, 2016
View reviewed changes
src/core/sys/posix/arpa/inet.d Outdated
const(char)* inet_ntop(int, in void*, char*, socklen_t);
int inet_pton(int, in char*, void*);
}
else version( NetBSD )
Copy link
Member

@ibuclaw ibuclaw Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that druntime is inconsistent everywhere about this. But I'd rather all new code follow the same (standard?) convention for version statements.

else version (NetBSD)
{

@joakim-noah
Copy link
Contributor

joakim-noah commented Feb 4, 2016

Skimmed just to make sure all changes are isolated to version(NetBSD) blocks, looks good on that front.

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 5561966 to e4e3106 Compare February 4, 2016 12:04
@sibnick
Copy link
Contributor Author

sibnick commented Feb 4, 2016

replace version( NetBSD ) with version(NetBSD)
remove blank lines
dirent.d : add version block for each known tested platform, using static assert (0) for the else branch

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from e4e3106 to 3b9371e Compare February 17, 2016 18:10
@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 3b9371e to b74c724 Compare February 27, 2016 17:30
@sibnick sibnick force-pushed the netbsd_core_sys_posix branch 3 times, most recently from 4a9ff40 to 95459fc Compare March 8, 2016 12:44
@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 95459fc to 4e7509d Compare March 14, 2016 17:34
@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 4e7509d to a21504b Compare January 31, 2017 08:39
@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

❗ No coverage uploaded for pull request head (netbsd_core_sys_posix@a21504b).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bf08d...a21504b. Read the comment docs.

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from a21504b to 62f5ad9 Compare February 1, 2017 02:42
@ibuclaw
Copy link
Member

ibuclaw commented Feb 13, 2017

Looks like you missed one blank line. Other than that looks ok to me.

@sibnick
Copy link
Contributor Author

sibnick commented Feb 13, 2017 •
edited
Loading

Iain
Are you talking about last empty line in termios.d?

I added empty line to termios.d and remove one blank line in poll.d

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 62f5ad9 to 625398d Compare February 14, 2017 02:21
@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 625398d to 3cd656d Compare February 14, 2017 02:25
@ibuclaw
Copy link
Member

ibuclaw commented Feb 14, 2017

@nrTQgc - there was a comment from @joakim-noah that was listed as not updated last time I looked. I can't see it now so I guess all is OK.

joakim-noah
joakim-noah suggested changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@joakim-noah joakim-noah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed to make sure changes are encapsulated and for formatting: once these changes are made, can approve.

src/core/sys/posix/pthread.d Outdated
enum PTHREAD_COND_INITIALIZER = pthread_cond_t(0x55550005);
enum PTHREAD_RWLOCK_INITIALIZER = pthread_rwlock_t(0x99990009);
}

Copy link
Contributor

@joakim-noah joakim-noah Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line

src/core/sys/posix/signal.d Outdated
int sa_flags;
}
}
else version(NetBSD)
Copy link
Contributor

@joakim-noah joakim-noah Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OpenBSD

src/core/sys/posix/signal.d Outdated
int sigpause(int);
int sigrelse(int);
}

Copy link
Contributor

@joakim-noah joakim-noah Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch from 3cd656d to dd13e98 Compare March 13, 2017 07:02
@sibnick
Copy link
Contributor Author

sibnick commented Mar 15, 2017

joakim-noah - I fixed you issues

@dnadlinger
Copy link
Contributor

dnadlinger commented Mar 15, 2017

Merging as it has been okay'd by two reviewers.

@dlang-bot dlang-bot merged commit be8b8ea into dlang:master Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@joakim-noah joakim-noah joakim-noah requested changes

@ibuclaw ibuclaw ibuclaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sibnick @joakim-noah @codecov-io @ibuclaw @dnadlinger @dlang-bot