This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix range violation in multithreaded application compiled with -profile=gc option#1664
Closed
japplegame wants to merge 2 commits intodlang:masterfrom
japplegame:patch-1
Closed
Fix range violation in multithreaded application compiled with -profile=gc option#1664japplegame wants to merge 2 commits intodlang:masterfrom japplegame:patch-1
japplegame wants to merge 2 commits intodlang:masterfrom
japplegame:patch-1
Conversation
…le=gc option Possible related issue https://issues.dlang.org/show_bug.cgi?id=14511
Contributor
|
Please follow the D style guide |
Member
|
This will not fix anything in the long run. |
UplinkCoder
suggested changes
Oct 5, 2016
Member
UplinkCoder
left a comment
UplinkCoder
left a comment
There was a problem hiding this comment.
Please use a Mutex if you want this to work multithreaded.
Author
|
No. The range violation happens because of wrong merging several TLS arrays into one. There is no race conditions and no need of additional mutexes, because the code is already synchronized, see line 90 |
Author
|
Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible related issue https://issues.dlang.org/show_bug.cgi?id=14511