This repository was archived by the owner on Oct 12, 2022. It is now read-only.
[REG] Simple multithreaded program + "-profile=gc" = crash#1803
Merged
WalterBright merged 1 commit intodlang:stablefrom Apr 6, 2017
Merged
[REG] Simple multithreaded program + "-profile=gc" = crash#1803WalterBright merged 1 commit intodlang:stablefrom
WalterBright merged 1 commit intodlang:stablefrom
Conversation
Fixes issue 15947 (https://issues.dlang.org/show_bug.cgi?id=15947) Fixes issue 14511 (https://issues.dlang.org/show_bug.cgi?id=14511) Root problem was trying to increment non-existent AA field upon merging profile stats. The code was also simplified to remove unnecessary condition.
Contributor
Contributor
Author
Contributor
Author
|
Thanks! @MartinNowak is it possible to do merge of stable into master without waiting for next point release? I am working on |
|
I made a similar PR many months ago - #1664 |
Member
|
You're right and you're justified in being annoyed. I apologize. |
tramker
pushed a commit
to tramker/druntime
that referenced
this pull request
Jun 9, 2017
[REG] Simple multithreaded program + "-profile=gc" = crash Signed-off-by: Martin Krejcirik <mk@krej.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 15947 (https://issues.dlang.org/show_bug.cgi?id=15947)
Fixes issue 14511 (https://issues.dlang.org/show_bug.cgi?id=14511)
Root problem was trying to increment non-existent AA field upon merging profile
stats. The code was also simplified to remove unnecessary condition.