Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Issue 12125: do not enforce specific MS C runtime#1691

Merged
MartinNowak merged 2 commits intodlang:stablefrom
rainers:nodefaultlib
Jan 18, 2017
Merged

Issue 12125: do not enforce specific MS C runtime#1691
MartinNowak merged 2 commits intodlang:stablefrom
rainers:nodefaultlib

Conversation

@rainers
Copy link
Member

@rainers rainers commented Nov 6, 2016

druntime.lib is agnostic to the used MS C runtime, but preselects one. Creating the automatic reference when building main/WinMain/DllMain is good enough.

@rainers
Copy link
Member Author

rainers commented Nov 6, 2016

I guess the win64 build fails because the auto tester still tries to patch win64.mak, but fails because the same line is modified in this PR. @braddr Any plan to remove the patching and use command line options instead?

@rainers rainers force-pushed the nodefaultlib branch 2 times, most recently from 85746fa to 20e69d1 Compare November 9, 2016 22:16
@TurkeyMan
Copy link
Contributor

Looks amazing to me!

@PetarKirov
Copy link
Member

Ping @MartinNowak this seems to be ready to to.

@rainers
Copy link
Member Author

rainers commented Jan 7, 2017

Now that the other PRs are included in Beta 2.073.0-b1, this change should also be merged to complete https://issues.dlang.org/show_bug.cgi?id=11961 and https://issues.dlang.org/show_bug.cgi?id=12125

Does this have to be retargetted to stable now?

@rainers rainers changed the base branch from master to stable January 14, 2017 22:22
@rainers
Copy link
Member Author

rainers commented Jan 14, 2017

Rebased to stable. The new option -mscrt (http://dlang.org/dmd-windows.html#switch-mscrt) is dysfunctional without this.

@MartinNowak
Copy link
Member

Rebased to stable. The new option -mscrt (http://dlang.org/dmd-windows.html#switch-mscrt) is dysfunctional without this.

The new options isn't in the changelog! Please add it (dmd/stable), see https://github.com/dlang/dmd/tree/stable/changelog for the new format.

@MartinNowak
Copy link
Member

Auto-merge toggled on

@MartinNowak MartinNowak merged commit 0dc5d1d into dlang:stable Jan 18, 2017
@rainers
Copy link
Member Author

rainers commented Jan 18, 2017

Thanks, changelog entry dlang/dmd#6467

make -C ../dlang.org -f posix.mak pending_changelog

This target just prints "This command will be available soon." both on stable and master, so I can't preview it locally, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants