Issue 12125: do not enforce specific MS runtime#4891
Merged
dnadlinger merged 1 commit intodlang:masterfrom Nov 13, 2016
Merged
Conversation
Member
Author
|
I guess the win64 build fails because the auto tester still tries to patch win64.mak, but fails because the same line is modified in this PR. @braddr Any plan to remove the patching and use command line options instead? |
rainers
force-pushed
the
nodefaultlib
branch
from
dbd4369 to
2268f20
Compare
Contributor
|
LGTM, but I'm not an approved reviewer :( |
dnadlinger
approved these changes
Nov 13, 2016
Contributor
|
Auto-merge toggled on |
Contributor
|
There's one more of these same patches in druntime... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phobos.lib is agnostic to the used MS C runtime, but preselects one. Creating the automatic reference when building main/WinMain/DllMain is good enough.
Needs corresponding druntime change to be effective: dlang/druntime#1691