Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Updated makefile to use generated/os/release/model/dmd#1779

Merged
andralex merged 1 commit intodlang:masterfrom
RazvanN7:Makefile_change
Mar 2, 2017
Merged

Updated makefile to use generated/os/release/model/dmd#1779
andralex merged 1 commit intodlang:masterfrom
RazvanN7:Makefile_change

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Mar 1, 2017

No description provided.

@dnadlinger
Copy link
Contributor

Does this handle multilib builds, i.e. the building 32 bit libraries on a 64 bit system part? If not, is this a configuration that is important for DMD in the first place? (I suppose one could always manually set DMD or just build a 32 bit copy of it as well.)

@wilzbach
Copy link
Contributor

wilzbach commented Mar 2, 2017

Does this handle multilib builds, i.e. the building 32 bit libraries on a 64 bit system part?

Yes, $(MODEL) is set based on the system whereas $(MODEL_FLAG) (by default set to $(MODEL)) is used for building the libraries.

This is part of the osmodel.mak

edit: after having another look at the posix.mak it seems that one currently needs to set MODEL as well for multilib builds. So currently by default a 32-bit copy of DMD would be built.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you are going for Windows in another PR ;-)

@andralex
Copy link
Member

andralex commented Mar 2, 2017

Unclear on what the autotester issue is, but it looks like a one-off.

@andralex
Copy link
Member

andralex commented Mar 2, 2017

Auto-merge toggled on

@andralex
Copy link
Member

andralex commented Mar 2, 2017

@RazvanN7 please push again your repo so it kicks off the autotester

@andralex
Copy link
Member

andralex commented Mar 2, 2017

I'll take a risk to actually merge this

@andralex andralex merged commit a4e01a8 into dlang:master Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants