Skip to content

Comments

Updated makefile to use generated/os/release/model/dmd#5223

Merged
andralex merged 1 commit intodlang:masterfrom
RazvanN7:Makefile_change
Mar 2, 2017
Merged

Updated makefile to use generated/os/release/model/dmd#5223
andralex merged 1 commit intodlang:masterfrom
RazvanN7:Makefile_change

Conversation

@RazvanN7
Copy link
Collaborator

@RazvanN7 RazvanN7 commented Mar 1, 2017

No description provided.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to update the win32.mak and win64.mak in this or another PR?

@dnadlinger
Copy link
Contributor

dnadlinger commented Mar 1, 2017

See dlang/druntime#1779.

@RazvanN7
Copy link
Collaborator Author

RazvanN7 commented Mar 2, 2017

@wilzbach As far as I can see the phobos/druntime windows versions do not use the binary generated in src/dmd. It seems that the windows installer puts the binary in dmd2/bin/dmd. I don't think that this should be changed. Maybe I am missing something

@wilzbach
Copy link
Contributor

wilzbach commented Mar 2, 2017

@wilzbach As far as I can see the phobos/druntime windows versions do not use the binary generated in src/dmd. It seems that the windows installer puts the binary in dmd2/bin/dmd. I don't think that this should be changed. Maybe I am missing something

Oh that's really weird behavior. I didn't consider this. Sorry.
Well, it seems like you aren't.
Only tools and dlang.org left then :)

@andralex andralex merged commit 9e75459 into dlang:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants