Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Revert "Revert "Add SO_REUSEPORT constant""#1887

Closed
wilzbach wants to merge 1 commit intomasterfrom
revert-1885-revert-1879-soreusse
Closed

Revert "Revert "Add SO_REUSEPORT constant""#1887
wilzbach wants to merge 1 commit intomasterfrom
revert-1885-revert-1879-soreusse

Conversation

@wilzbach
Copy link
Contributor

This should be pulled once Vibe.d has changed and Jenkins is green :)

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@PetarKirov PetarKirov force-pushed the revert-1885-revert-1879-soreusse branch from 243df32 to 15fc6bf Compare September 1, 2017 11:56
@PetarKirov
Copy link
Member

@s-ludwig Can we upgrade diet-ng and dub to the latest vibe.d version? The use of an older vibe.d is a blocker for this PR.

@s-ludwig
Copy link
Member

s-ludwig commented Sep 1, 2017

The updated DUB should already be in the latest 2.076.0-rc.1. I'll upgrade the example in diet-ng to use 0.8.x.

@PetarKirov
Copy link
Member

Thanks, so I guess when the official release for 2.076.0 is tagged, a new (non beta) release for dub will be tagged too and Jenkins will pick it up.

@s-ludwig
Copy link
Member

s-ludwig commented Sep 1, 2017

Just noticed that Martin has tagged the release just a few minutes ago. The new version should now be available.

@PetarKirov
Copy link
Member

@s-ludwig unfortunately the new release broke Jenkins :/

@wilzbach wilzbach force-pushed the revert-1885-revert-1879-soreusse branch from 15fc6bf to 869da8f Compare December 2, 2017 13:22
@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 2, 2017

Rebased this PR to the latest master, s.t. Jenkins gets retriggered and we hopefully can move on (:

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 2, 2017

../../.dub/packages/vibe-d-0.8.0/vibe-d/core/vibe/core/drivers/libevent2.d(365,63): Error: vibe.core.drivers.utils.SO_REUSEPORT at ../../.dub/packages/vibe-d-0.8.0/vibe-d/core/vibe/core/drivers/utils.d(53,10) conflicts with core.sys.posix.sys.socket.SO_REUSEPORT at /var/lib/jenkins/dlang_projects@2/distribution/bin/../imports/core/sys/posix/sys/socket.d(306,13)

It looks like we need to bump the vibe.d version used @ DUB.

@dlang-bot dlang-bot added Needs Rebase needs a `git rebase` performed and removed Needs Rebase needs a `git rebase` performed labels Jan 1, 2018
@wilzbach wilzbach force-pushed the revert-1885-revert-1879-soreusse branch from 869da8f to f841730 Compare January 11, 2018 03:56
@wilzbach wilzbach requested a review from andralex as a code owner January 11, 2018 03:56
@wilzbach
Copy link
Contributor Author

Rebased to master. As there have been a couple of releases of vibe-d, this should most likely pass now.

@wilzbach
Copy link
Contributor Author

This commit cannot be be built

Looks like Jenkins has troubles with PRs from dlang branches -> #2036

@wilzbach wilzbach closed this Jan 11, 2018
@wilzbach wilzbach deleted the revert-1885-revert-1879-soreusse branch January 11, 2018 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants