Add overrides for __simd intrinsics#1900
Add overrides for __simd intrinsics#1900dlang-bot merged 1 commit intodlang:masterfrom ibuclaw:simdcasts
Conversation
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#1900" |
|
Replaced with templates. Can't add unittests because of https://issues.dlang.org/show_bug.cgi?id=17751 |
wilzbach
left a comment
There was a problem hiding this comment.
Looks reasonable to me, but I'm no expert on simD
|
Marking as blocked. I'll rebase and add unittests so the compiler ICE gets triggered (so that we'll know when dmd is fixed). @MartinNowak is this fine from a high level design? @WalterBright don't suppose you can have a look at the backens related ICE? |
|
I don't know what the rationale of this is. There's no bugzilla issue referenced, no explanation here, no comments in the code? |
|
@WalterBright see dmd pr and linked bug there. I want to make it illegal to implicitly cast to void vector, but these intrinsics block the patch. |
Bug 17751 was fixed with dlang/dmd#7216. Is this still "Blocked"? |
|
Fix turned my proposal into an error. If only dmd did constant propagation it would not be an error though... The imm8 template should instead have the following signature. |
|
I've restarted CircleCI, hopefully the failure was intermittent. |
Probably caused by a very old config file. I rebased to |
|
Raises Eyebrows. I think I will have to go through some of the tests though to make sure they are OK. I don't recall whether coverage is complete here, I can see a couple commented out tests. I guess I can switch over the XMM test file in dmd to use these templates and see what blows up. :-) |
This is blocking dlang/dmd#7065