This repository was archived by the owner on Oct 12, 2022. It is now read-only.
core.simd: Fix simd templates to take parameters by reference#3155
Closed
ibuclaw wants to merge 2 commits intodlang:masterfrom
ibuclaw:simdrefargs
Closed
core.simd: Fix simd templates to take parameters by reference#3155ibuclaw wants to merge 2 commits intodlang:masterfrom ibuclaw:simdrefargs
ibuclaw wants to merge 2 commits intodlang:masterfrom
ibuclaw:simdrefargs
Conversation
ibuclaw
requested review from
MartinNowak,
WalterBright and
schveiguy
as code owners
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3155" |
thewilsonator
approved these changes
Jul 11, 2020
Member
Author
|
I have no time to look into why win64 doesn't work, I'll just revert the originating PR then. (#3157) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like nobody is using any of these templates, and #1900 should probably be reverted. It looks like they are all broken anyway unless changed to accept parameters by reference.
Should be enough to get CI for dlang/dmd#7065 green.