Add musl libc definitions to core/stdc/*#2066
Conversation
|
Thanks for your pull request, @yshui! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
ibuclaw
left a comment
ibuclaw
left a comment
There was a problem hiding this comment.
LGTM. Last nits and we're there.
src/core/stdc/fenv.d
Outdated
| else version( CRuntime_Musl ) | ||
| { | ||
| version (X86_64) { | ||
| struct fenv_t { |
There was a problem hiding this comment.
Nit, can we have curly braces on new lines?
src/core/stdc/math.d
Outdated
| ? __fpclassify(x) | ||
| : __fpclassifyl(x); | ||
| } | ||
| static uint __FLOAT_BITS(float __f) |
There was a problem hiding this comment.
static isn't doing anything here. Should this instead be private?
src/core/stdc/math.d
Outdated
| __u.__f = __f; | ||
| return __u.__i; | ||
| } | ||
| static ulong __DOUBLE_BITS(double __f) |
src/core/stdc/stdio.d
Outdated
| } | ||
| else version( CRuntime_Musl ) | ||
| { | ||
| union fpos_t { |
src/core/stdc/stdio.d
Outdated
| extern shared FILE* stdout; | ||
| /// | ||
| extern shared FILE* stderr; | ||
| enum { |
| enum { | ||
| _IOFBF = 0, | ||
| _IOLBF = 1, | ||
| _IONBF = 2, |
There was a problem hiding this comment.
Add /// comment for each member.
|
Done |
joakim-noah
left a comment
joakim-noah
left a comment
There was a problem hiding this comment.
Just checked for scoping, looks good. @ZombineDev, if you approve, should be merged.
4 participants
This is splitted from #1997.
I think I addressed all the comments. Thanks to all the reviewers.