Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Add musl libc definitions to core/sys/posix/*#2067

Merged
dlang-bot merged 1 commit intodlang:masterfrom
yshui:musl_core_sys_posix
Jan 30, 2018
Merged

Add musl libc definitions to core/sys/posix/*#2067
dlang-bot merged 1 commit intodlang:masterfrom
yshui:musl_core_sys_posix

Conversation

@yshui
Copy link
Contributor

@yshui yshui commented Jan 28, 2018

See #2066

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @yshui! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@joakim-noah joakim-noah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's properly scoped, so fine.

@ibuclaw ibuclaw closed this Jan 30, 2018
@ibuclaw ibuclaw reopened this Jan 30, 2018
@dlang-bot dlang-bot merged commit bff4d4b into dlang:master Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants