[Trivial] Match the module name to the file name (pthread_np)#2107
[Trivial] Match the module name to the file name (pthread_np)#2107wilzbach merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @dkgroot! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Note: The file does not seem to be used at this moment, and was copied over from the FreeBSD implementation (which does not seem to use it's version either). Maybe instead of renaming the module name, we should opt to remove this file. Not sure what the reason for it's creation is or was. Please let me know what you would like to happen ! |
|
|
@wilzbach I don't mind if the file stays, i just want to match the filename to the module name (got some errors when running unittests in ldc because of the name mismatch). |
|
I assume that LDC doesn't support FreeBSD (or at least no one builds it regularly for it), hence it didn't come up earlier? |
|
Thanks guys ! |
This caused a unittest issue in ldc-ltsmaster. Would like to keep these files in sync.
Note: The file does not seem to be used at this moment, and was copied over from the FreeBSD implementation (which does not seem to use it's version either). Maybe instead of renaming the module name, we should opt to remove this file. Not sure what the reason for it's creation is or was.