Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

[Trivial] Match the module name to the file name (pthread_np)#2107

Merged
wilzbach merged 1 commit intodlang:masterfrom
dkgroot-dlang:fix_dfly_pthread
Feb 28, 2018
Merged

[Trivial] Match the module name to the file name (pthread_np)#2107
wilzbach merged 1 commit intodlang:masterfrom
dkgroot-dlang:fix_dfly_pthread

Conversation

@dkgroot
Copy link
Contributor

@dkgroot dkgroot commented Feb 23, 2018

This caused a unittest issue in ldc-ltsmaster. Would like to keep these files in sync.

Note: The file does not seem to be used at this moment, and was copied over from the FreeBSD implementation (which does not seem to use it's version either). Maybe instead of renaming the module name, we should opt to remove this file. Not sure what the reason for it's creation is or was.

@dlang-bot dlang-bot added the Trivial typos, formatting, comments label Feb 23, 2018
@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 23, 2018

Thanks for your pull request and interest in making D better, @dkgroot! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dkgroot
Copy link
Contributor Author

dkgroot commented Feb 23, 2018

Note: The file does not seem to be used at this moment, and was copied over from the FreeBSD implementation (which does not seem to use it's version either). Maybe instead of renaming the module name, we should opt to remove this file. Not sure what the reason for it's creation is or was.

Please let me know what you would like to happen !

@dkgroot dkgroot changed the base branch from master to stable February 23, 2018 19:07
@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Feb 23, 2018
@dkgroot dkgroot changed the base branch from stable to master February 23, 2018 19:07
@wilzbach
Copy link
Contributor

Not sure what the reason for it's creation is or was.

#1060

Just tried to use pthread_suspend_np to fix Issue 13416. Didn't work out, but the header might still be useful to someone else.

@dkgroot
Copy link
Contributor Author

dkgroot commented Feb 28, 2018

@wilzbach I don't mind if the file stays, i just want to match the filename to the module name (got some errors when running unittests in ldc because of the name mismatch).

@wilzbach wilzbach merged commit 3db3820 into dlang:master Feb 28, 2018
@wilzbach
Copy link
Contributor

I assume that LDC doesn't support FreeBSD (or at least no one builds it regularly for it), hence it didn't come up earlier?

@dkgroot
Copy link
Contributor Author

dkgroot commented Feb 28, 2018

Thanks guys !

dkgroot added a commit to dkgroot-ldc/druntime that referenced this pull request Mar 1, 2018
dkgroot added a commit to dkgroot-ldc/druntime that referenced this pull request May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants