Add DragonFly bootstrap support (ltsmaster) by dkgroot · Pull Request #109 · ldc-developers/druntime

dkgroot · 2017-12-21T17:57:00Z

All druntime files except for:

src/core/sys/posix/
src/core/sys/dragonflybsd/
They will be posted in a separate PR

Related PR's:

ldc
- ldc:ltsmaster
- druntime:ltsmaster
- phobos:ltsmaster
- dmd-testsuite:ltsmaster
dlang:
- dlang/dmd:master
- dlang/druntime:master
- dlang/phobos:master (merged already)

joakim-noah · 2017-12-24T10:51:53Z

No point reviewing your ltsmaster druntime pulls yet, since you're still updating your upstream pulls. If and when those are merged, I'll port them back to this branch, then you can limit these pulls to changes you had to make to just this older branch.

dkgroot · 2017-12-29T22:51:18Z

@joakim-noah Thanks for the heads up.
It looks like it might be a while before all three upstream druntime PR's are through (lots of reviewers, which is a good thing, but does take a while)

dkgroot · 2018-01-04T14:50:48Z

Created an example CI for DragonFly, reusing most of the CI scripting i used to build the dmd version.
Note: Just a proof of concept and a way to show what would is needed to run a VM inside a CI VM, and communicate with this wrapped VM over ssh.

joakim-noah · 2018-02-15T10:52:21Z

Update to the upstream merged changes and I'll pull.

dkgroot · 2018-02-22T11:28:02Z

@joakim-noah.

Rebased
Synced up to dlang/PR/1999 (manually)

dkgroot · 2018-02-22T20:20:36Z

Ready to Merge
DFly SemaphoreCI

joakim-noah

Some tweaks and questions.

joakim-noah · 2018-02-23T09:05:42Z

src/core/stdc/math.d

    ///
    enum int FP_ILOGBNAN      = int.max;
 }
+version (DragonFlyBSD)


Forgot an else here.

joakim-noah · 2018-02-23T09:07:13Z

src/core/stdc/stdio.d

  {
    import core.sys.posix.sys.types;
  }
+  version (DragonFlyBSD)


An else would be good here.

joakim-noah · 2018-02-23T09:09:02Z

src/core/stdc/stdio.d

    int getc(FILE* stream)        { return fgetc(stream);   }
    ///
-    int putc(int c, FILE* stream) { return fputc(c,stream); }
+    int putc(int c, FILE* stream) { return fputc(c, stream); }


I don't see the point of these two spacing tweaks.

joakim-noah · 2018-02-23T09:26:34Z

src/rt/dmain2.d

            fldcw   fpucw;
        }
    }
+    version (DragonFlyBSD) version (D_InlineAsm_X86)


I thought you're not supporting 32-bit? Take this out.

Correct 👍

joakim-noah · 2018-02-23T09:29:26Z

src/core/sys/dragonflybsd/pthread_np.d

- * Authors: Martin Nowak,Diederik de Groot(port:DragonFlyBSD)
- * Copied:  From core/sys/freebsd/sys
- */
-module core.sys.dragonflybsd.pthread;


Why remove this file if it's there upstream?

I can add it back in (but it is not used in the ltsmaster for now.
I would have to change the either the filename or the modulename. Which one do you prefer ?

The name doesn't have to match, just leave it alone without a revert. If you want to fix it, fix it upstream.

Ok...
Note: I did get an error when running the (ninja) unittests (which this file does not even contain), about pthread_np not existing.

Ninja warning or error? It can spit a warning for a file that's not in the CMake file, not a big deal.

Are you saying this file is used upstream in master but not in this branch? A grep turned up no use in master either.

Actually an error (if i remember correctly, would have to rerun to check).
Link: dlang#2107

Nope doesn't seem to be used in master yet either (copied over from the freebsd implementation, but does not seem to be required. Maybe we should remove it altogetehr (in retrospect)).

dlang#2107 got merged upstream.

joakim-noah · 2018-02-23T13:38:09Z

src/core/stdc/stdio.d

    int getchar()                 { return getc(stdin);     }
    ///
-    int putchar(int c)            { return putc(c,stdout);  }
+    int putchar(int c)            { return putc(c, stdout);  }


I mentioned two spacing tweaks, this is the other one I don't see a need for.

dkgroot · 2018-03-01T21:31:00Z

Builds cleanly and all unittests passed
See: https://semaphoreci.com/dkgroot/ldc_dragonfly_ci/branches/master/builds/32

joakim-noah · 2018-03-02T02:31:41Z

Been busy with other stuff, will get to this this weekend.

joakim-noah · 2018-03-04T08:19:54Z

src/core/stdc/stdio.d

    int getchar()                 { return getc(stdin);     }
    ///
    int putchar(int c)            { return putc(c,stdout);  }
+


Take this out too.

dkgroot · 2018-03-04T12:31:06Z

@joakim-noah Thanks a lot !

dkgroot force-pushed the dragonfly-ltsmaster branch from 96ba97c to 405722d Compare February 22, 2018 11:24

joakim-noah suggested changes Feb 23, 2018

View reviewed changes

dkgroot force-pushed the dragonfly-ltsmaster branch from 62d08c0 to 86b75bc Compare February 23, 2018 13:26

joakim-noah reviewed Feb 23, 2018

View reviewed changes

dkgroot force-pushed the dragonfly-ltsmaster branch from bed7f9a to 7dd054d Compare March 1, 2018 20:52

Add DragonFly support to ldc:druntime

c4294dc

joakim-noah reviewed Mar 4, 2018

View reviewed changes

dkgroot force-pushed the dragonfly-ltsmaster branch from 90e5da3 to c4294dc Compare March 4, 2018 10:15

joakim-noah merged commit e424515 into ldc-developers:ldc-ltsmaster Mar 4, 2018

dkgroot deleted the dragonfly-ltsmaster branch March 4, 2018 12:31

Comments

Conversation

dkgroot commented Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joakim-noah commented Dec 24, 2017

Uh oh!

dkgroot commented Dec 29, 2017

Uh oh!

dkgroot commented Jan 4, 2018

Uh oh!

joakim-noah commented Feb 15, 2018

Uh oh!

dkgroot commented Feb 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkgroot commented Feb 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joakim-noah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joakim-noah Feb 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkgroot commented Mar 1, 2018

Uh oh!

joakim-noah commented Mar 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkgroot commented Mar 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkgroot commented Dec 21, 2017 •

edited

Loading

dkgroot commented Feb 22, 2018 •

edited

Loading

dkgroot commented Feb 22, 2018 •

edited

Loading

joakim-noah Feb 23, 2018 •

edited

Loading