Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2499" |
wilzbach
force-pushed
the
quote-win64
branch
2 times, most recently
from
d44b097 to
bc47055
Compare
|
Read auto-merge when you're done, I'll be away for a bit. |
| BUILD=release | ||
| OS=windows | ||
| DMD=$(DMD_DIR)\generated\$(OS)\$(BUILD)\$(MODEL)\dmd | ||
| DMD="$(DMD_DIR)\generated\$(OS)\$(BUILD)\$(MODEL)\dmd" |
There was a problem hiding this comment.
I think we should never quote when assigning to a variable, see also #2438
That also avoids the horrible quoting when invoking a sub make command, e.g. https://github.com/dlang/druntime/pull/2499/files#diff-e35cbd05831954a48feae8130a5df3f4R89 (even broken in this case).
|
I suspect this PR broke the build on master and other PRs. AFAICT win-farm2 uses a different VC path and fails because it contains spaces. |
|
Argh sorry about this. Here's the revert -> #2500 We really need to move away from the auto-tester or at least make all its clients behave the same 😱 |
4 participants
The escaping is required for dlang/dmd#9398.