Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Revert "Quote variables in win64.mak"#2500

Merged
wilzbach merged 1 commit intomasterfrom
revert-2499-quote-win64
Mar 1, 2019
Merged

Revert "Quote variables in win64.mak"#2500
wilzbach merged 1 commit intomasterfrom
revert-2499-quote-win64

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Mar 1, 2019

Reverts #2499 (as it appears to have broken win-farm2)

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2500"

@wilzbach wilzbach requested a review from andralex as a code owner March 1, 2019 08:39
@ghost
Copy link

ghost commented Mar 1, 2019

Manual merge needed maybe ? The fix seems to be affected by the problem it's supposed to solve.

@wilzbach wilzbach merged commit 764c950 into master Mar 1, 2019
@wilzbach wilzbach deleted the revert-2499-quote-win64 branch March 1, 2019 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants