Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Merge stable into master#3046

Merged
dlang-bot merged 5 commits intodlang:masterfrom
MoonlightSentinel:master
Apr 19, 2020
Merged

Merge stable into master#3046
dlang-bot merged 5 commits intodlang:masterfrom
MoonlightSentinel:master

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

This should finally unblock dlang/dmd#11027

MoonlightSentinel and others added 5 commits April 19, 2020 12:59
Fix Issue 20748 - Deprecation for assert using shared type and checka…
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Fix Issue 20750 - checkaction=context segfaults for null references
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20748 regression Deprecation for assert using shared type and checkaction=context
20750 minor checkaction=context segfaults for null references

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3046"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 19, 2020
@dlang-bot dlang-bot merged commit 6861dd2 into dlang:master Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants