Make win32.mak compatible with MODEL=32omf#3703
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3703" |
ca82a78 to
61cdd7a
Compare
The previous assumption was `MODEL=32` because `MODEL=32mscoff` is built by `win64.mak`. Verified locally because Azure requires further changes outside of this repository.
61cdd7a to
dafc74a
Compare
|
This will need to be force-merged because it requires additional changes to |
|
@MoonlightSentinel Ping me when you need this merged. |
|
Submitted the required changes to |
|
Azure successfully built druntime! Just one patch left... (Phobos/win32.mak) |
|
Can you temporarily mark the Azure job as not required? Or do we have to modify the configuration until the Phobos PR is merged? |
|
I don't know how to do that and I might not have the rights, however, I can force merge this if that is required. |
|
It'll be required - neither makefile update is sufficient on its own (this fails due to the outdated |
|
@MoonlightSentinel Thanks for fixing this! |
The previous assumption was
MODEL=32becauseMODEL=32mscoffis built bywin64.mak.Verified locally because Azure requires further changes outside of this repository.