Make win32.mak compatible with MODEL=32omf#8367
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8367" |
|
Why is this a draft? Maybe I can force merge this one, but it needs to be a non-draft. |
|
Yep, I can force merge this one. Ping me when it's ready |
|
Initially had hoped that the Druntime PR could be merged first - in case there are subtle difference between Azure and my local setup. But this should be good to go once all other jobs pass. |
The previous assumption was MODEL=32 because MODEL=32mscoff is built by win64.mak. Verified locally because Azure requires further changes outside of this repository.
The previous assumption was MODEL=32 because MODEL=32mscoff is built by
win64.mak.
Verified locally because Azure requires further changes outside of this repository - see dlang/druntime#3703.