Skip to content

Make win32.mak compatible with MODEL=32omf#8367

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
MoonlightSentinel:ci/fix-windows-default-switch
Jan 25, 2022
Merged

Make win32.mak compatible with MODEL=32omf#8367
RazvanN7 merged 1 commit intodlang:masterfrom
MoonlightSentinel:ci/fix-windows-default-switch

Conversation

@MoonlightSentinel
Copy link
Contributor

The previous assumption was MODEL=32 because MODEL=32mscoff is built by
win64.mak.

Verified locally because Azure requires further changes outside of this repository - see dlang/druntime#3703.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8367"

@RazvanN7
Copy link
Collaborator

Why is this a draft? Maybe I can force merge this one, but it needs to be a non-draft.

@RazvanN7 RazvanN7 marked this pull request as ready for review January 25, 2022 15:28
@RazvanN7
Copy link
Collaborator

Yep, I can force merge this one. Ping me when it's ready

@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Jan 25, 2022

Initially had hoped that the Druntime PR could be merged first - in case there are subtle difference between Azure and my local setup. But this should be good to go once all other jobs pass.

@RazvanN7 RazvanN7 merged commit 517abbf into dlang:master Jan 25, 2022
@MoonlightSentinel MoonlightSentinel deleted the ci/fix-windows-default-switch branch January 25, 2022 16:12
The previous assumption was MODEL=32 because MODEL=32mscoff is built by
win64.mak.

Verified locally because Azure requires further changes outside of this
repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants