This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Issue 4360 - Allow intrinsics in core.bitop to operate as intrinsics#6
Closed
complexmath wants to merge 1 commit intodlang:masterfrom
Closed
Issue 4360 - Allow intrinsics in core.bitop to operate as intrinsics#6complexmath wants to merge 1 commit intodlang:masterfrom
complexmath wants to merge 1 commit intodlang:masterfrom
Conversation
Member
There was a problem hiding this comment.
I think examples using assert are better because with writing to stdout there's always the need to corroborate the output with each call to write.
Contributor
Author
There was a problem hiding this comment.
Oops, I missed that when copying the file from Phobos.
Member
|
I pulled these changes and updated the examples, creating unittests for those few functions in the process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be applied after the following dmd pull request is accepted:
dlang/dmd#5