make Thread.sm_this a plain TLS value#456
Conversation
- this became possible, because the TLS emulation no longer uses the Thread.getThis() instance - Windows use impersonate_thread to set sm_this when attaching a foreign thread
make Thread.sm_this a plain TLS value
|
This pull request seems to have broken osx 32 and 64. It was pulled before the platform completed (because it was hung in the first druntime tests). Consequently, the master branch pulls are also hung on the same tests. It looks like infinite recursion.. which ought to lead to an eventual fault, but... (gdb) bt |
Revert "Merge pull request #456 from dawgfoto/useTLS"
|
@braddr @AndrejMitrovic's revert is in now, sorry about the mess |
|
No worries.. these sorts of failures are just rare enough that I haven't taught the auto tester how to watch for hung tests and deal with them yet. If only there were more hours in the day. Anyone wanna take a stab at adding it? |
Yep, I'll put it on my task list. This one here https://github.com/braddr/d-tester? |
|
yes.. we can discuss the details more, but not in this pull request. |
no longer uses the Thread.getThis() instance
when attaching a foreign thread