This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Merged
Conversation
Contributor
|
Great work! I'll see about applying the changes. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I'm finished with my GC optimization adventure because I'm fresh out of ideas. Of my four benchmarks, the only one that I didn't get a huge (2x or more) speedup on is actually spending about 1/3 of its total execution time and about half of its GC time in the sweep phase. From looking at the sweep code, I don't see any way to speed this up, as it's all a bunch of uniformly slow bit twiddling.
I've been testing my changes by making sure the Phobos, std.parallelism and dstats unittests (all of which use the GC to manage their memory) still pass with these, and by eating my own dogfood and using my modified GC for real work. AFAIK we don't have a real stress test suite for the GC, so I figure real world code that depends on it is the next best thing. I'd like to have these changes reviewed and tested on more real-world code so that we can get them in for next release.